Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #843: Fixed bug when single inheritance keys contain special chars #847

Merged
merged 1 commit into from Mar 21, 2014
Merged

Issue #843: Fixed bug when single inheritance keys contain special chars #847

merged 1 commit into from Mar 21, 2014

Conversation

acim
Copy link

@acim acim commented Mar 21, 2014

Fixed bug and contributed test

willdurand added a commit that referenced this pull request Mar 21, 2014
…squashed

Issue #843: Fixed bug when single inheritance keys contain special chars

Replace #843
@willdurand willdurand merged commit 25620fc into propelorm:master Mar 21, 2014
@acim acim deleted the 843-single-inheritance-keys-bugfix-squashed branch March 21, 2014 11:13
@marcj
Copy link
Member

marcj commented Mar 21, 2014

Pro tip: you don't have to create a new branch (and hence a new PR), when you've rebased/squashed commits. You can just overwrite your branch at the remote site via git push origin +branch_name.

@marcj
Copy link
Member

marcj commented Mar 21, 2014

Anyways, thanks :)

@acim
Copy link
Author

acim commented Mar 21, 2014

Thank you Marc :) This was my first contribution :)

@acim
Copy link
Author

acim commented May 7, 2014

@acim
Copy link
Author

acim commented May 7, 2014

Fix is finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants